diff options
| author | Taylor Mullen <[email protected]> | 2025-04-21 10:53:11 -0400 |
|---|---|---|
| committer | N. Taylor Mullen <[email protected]> | 2025-04-21 11:07:09 -0400 |
| commit | 81f0f618f7ecc439e67447bf98065d87e22483c0 (patch) | |
| tree | 82851f180c8ba5263427e3586bc738590fc49153 /packages/cli/src/tools/read-file.tool.ts | |
| parent | e351baf10f06d2a1d1872bf2a6d7e9e709effed9 (diff) | |
Fix Gemini Code's (GC) smarts.
- The tl;dr; is that GC couldn't see what the user was saying when tool call events happened in response. The rason why this was happening was because we were instantly invoking tools that the model told us to invoke and then instantly re-requesting. This resulted in the bug because the genai APIs can't update the chat history before a full response has been completed (doesn't know how to update if it's incomplete).
- To address the above issue I had to do quite the large refactor. The gist is that now turns truly drive everything on the server (vs. a server client split). This ensured that when we got tool invocations we could control when/how re-requesting would happen and then also ensure that history was updated. This change also meant that the server would act as an event publisher to enable the client to react to events rather than try and weave in complex logic between the events.
- A BIG change that this changeset incudes is the removal of all of the CLI tools in favor of the server tools.
- Removed some dead code as part of this
- **NOTE: Confirmations are still broken (they were broken prior to this); however, I've set them up to be able to work in the future, I'll dot hat in a follow up to be less breaking to others.**
Fixes https://b.corp.google.com/issues/412320087
Diffstat (limited to 'packages/cli/src/tools/read-file.tool.ts')
| -rw-r--r-- | packages/cli/src/tools/read-file.tool.ts | 67 |
1 files changed, 0 insertions, 67 deletions
diff --git a/packages/cli/src/tools/read-file.tool.ts b/packages/cli/src/tools/read-file.tool.ts deleted file mode 100644 index 206267be..00000000 --- a/packages/cli/src/tools/read-file.tool.ts +++ /dev/null @@ -1,67 +0,0 @@ -/** - * @license - * Copyright 2025 Google LLC - * SPDX-License-Identifier: Apache-2.0 - */ - -import { - ReadFileLogic, - ReadFileToolParams, - ToolResult, -} from '@gemini-code/server'; -import { BaseTool } from './tools.js'; -import { ToolCallConfirmationDetails } from '../ui/types.js'; - -/** - * CLI wrapper for the ReadFile tool - */ -export class ReadFileTool extends BaseTool<ReadFileToolParams, ToolResult> { - static readonly Name: string = ReadFileLogic.Name; - private coreLogic: ReadFileLogic; - - /** - * Creates a new instance of the ReadFileTool CLI wrapper - * @param rootDirectory Root directory to ground this tool in. - */ - constructor(rootDirectory: string) { - const coreLogicInstance = new ReadFileLogic(rootDirectory); - super( - ReadFileTool.Name, - 'ReadFile', - 'Reads and returns the content of a specified file from the local filesystem. Handles large files by allowing reading specific line ranges.', - (coreLogicInstance.schema.parameters as Record<string, unknown>) ?? {}, - ); - this.coreLogic = coreLogicInstance; - } - - /** - * Delegates validation to the core logic - */ - validateToolParams(_params: ReadFileToolParams): string | null { - return this.coreLogic.validateToolParams(_params); - } - - /** - * Delegates getting description to the core logic - */ - getDescription(_params: ReadFileToolParams): string { - return this.coreLogic.getDescription(_params); - } - - /** - * Define confirmation behavior here in the CLI wrapper if needed - * For ReadFile, we likely don't need confirmation. - */ - shouldConfirmExecute( - _params: ReadFileToolParams, - ): Promise<ToolCallConfirmationDetails | false> { - return Promise.resolve(false); - } - - /** - * Delegates execution to the core logic - */ - execute(params: ReadFileToolParams): Promise<ToolResult> { - return this.coreLogic.execute(params); - } -} |
