jcarr/libgit2/handles.go, branch v0.1.5Unnamed repository; edit this file 'description' to name the repository.
http://cgit.wit.com/jcarr/libgit2/atom?h=v0.1.52021-09-05T20:59:36ZMake all non-user-creatable structures non-comparable (#802)2021-09-05T20:59:36Zlhchavezlhchavez@lhchavez.com2021-09-05T20:59:36Zurn:sha1:dbe032c347b1a1308a4b880e7c5a06d8dfb4d507
This change makes all non-user-creatable structures non-comparable. This
makes it easier to add changes later that don't introduce breaking
changes from the go compatibility guarantees perspective.
This, of course, implies that this change _is_ a breaking change, but since
these structures are not intended to be created by users (or de-referenced),
it should be okay.Add a way to cleanly shut down the library (#578)2020-06-21T13:44:06Zlhchavezlhchavez@lhchavez.com2020-06-21T13:44:06Zurn:sha1:619a9c236bf79c63d955490c0803833004a47154
This change adds the Shutdown() method, so that the library can be
cleanly shut down. This helps significanly reduce the amount of noise in
the leak detector.handles: use real pointers to keep track of handles2016-02-18T16:33:44ZCarlos MartÃn Nietocmn@dwim.me2016-02-18T16:07:33Zurn:sha1:f1240e6565dfb70cfd22f4025c1453ca92ce0743
With the change to 1.6 rules, we couldn't use the Go pointers, so we
went with casting the list indices into pointers.
The runtime does not like this, however. It will sometimes detect that
we have a pointer with a very small value and consider it an invalid
pointer, bringing down the application with it.
Work around that by asking libc for the smallest amount of memory it'll
give us so we have an actual allocated pointer to use. We then use this
pointer value as the key in our map to find the Go object we're
tracking.
handles, merge: simplify code, don't copy file contents2016-02-17T05:34:43ZIan Lance Tayloriant@golang.org2016-02-17T05:34:43Zurn:sha1:a1f25eafec55509d49dffb4c84f7c5b729e6a85ehandles, merge, odb: changes for Go 1.6 pointer passing rules2016-01-08T02:37:46ZIan Lance Tayloriant@golang.org2016-01-08T02:37:46Zurn:sha1:42b11d403d91e25754fe60c63c26371fbb7a89a9
See http://tip.golang.org/cmd/cgo/#hdr-Passing_pointers .
Prevent slot int variable from being GCed.2015-07-26T22:02:40ZDmitri ShuralyovshurcooL@gmail.com2015-07-07T02:27:58Zurn:sha1:e1e1b4b1e164b4aba04e43f8b93c9a552fdc6ab4
Before this change, there were no users of slot int variable in the Go
world (just a pointer to it that ended up in C world only), so Go's
garbage collector would free it and its value could not retrieved later
(once a pointer to it comes back to Go world from C world).
Keep a pointer to it in the Go world so that does not happen.
Fixes #218.
handles: do not store handles by uintptr2015-05-22T07:50:16ZPatrick Steinhardtps@pks.im2015-05-22T07:50:16Zurn:sha1:1bd338af5e7a329c8ec5bd85500350795d0793d2
If we store values by uintptrs the GC may try to inspect their
values when it kicks in. As the pointers are most likely invalid,
this will result in an invalid pointer dereference, causing the
program to panic. We can fix this by storing values by an int
index value instead, returning pointers to those indices as
handles instead.
handles: print pointer handle on panic.2015-05-22T07:02:24ZPatrick Steinhardtps@pks.im2015-04-24T08:08:32Zurn:sha1:7ee534d0c50f6b7b54a6e8c83e0953a95a4cac22handles: start slot indices with 12015-05-22T07:02:24ZPatrick Steinhardtps@pks.im2015-04-24T07:35:58Zurn:sha1:0a336e4abdd7c949c9dd38037165e6a16c7d7ebf
Using 0 as the first slot indice leads to not being able to
differentiate between a handle to the first element or a
NULL-handle. As current code may check whether the pointer is
NULL, change the first indice to be 1 instead.
handles: correctly initialize all members2015-05-22T07:02:24ZPatrick Steinhardtps@pks.im2015-04-23T08:02:57Zurn:sha1:bde012f3d478752787bab0978e0bfaf5deefa42b