[no description] http://cgit.wit.com/dev/gemini-cli/atom?h=v0.2.2 2025-04-21T19:59:31Z 2025-04-21T19:59:31Z Jaana Dogan jbd@google.com 2025-04-21T19:59:31Z urn:sha1:baf39042c8631d53dfac4e57148404749cde14b3 2025-04-21T15:07:09Z Taylor Mullen ntaylormullen@google.com 2025-04-21T14:53:11Z urn:sha1:81f0f618f7ecc439e67447bf98065d87e22483c0 - The tl;dr; is that GC couldn't see what the user was saying when tool call events happened in response. The rason why this was happening was because we were instantly invoking tools that the model told us to invoke and then instantly re-requesting. This resulted in the bug because the genai APIs can't update the chat history before a full response has been completed (doesn't know how to update if it's incomplete). - To address the above issue I had to do quite the large refactor. The gist is that now turns truly drive everything on the server (vs. a server client split). This ensured that when we got tool invocations we could control when/how re-requesting would happen and then also ensure that history was updated. This change also meant that the server would act as an event publisher to enable the client to react to events rather than try and weave in complex logic between the events. - A BIG change that this changeset incudes is the removal of all of the CLI tools in favor of the server tools. - Removed some dead code as part of this - **NOTE: Confirmations are still broken (they were broken prior to this); however, I've set them up to be able to work in the future, I'll dot hat in a follow up to be less breaking to others.** Fixes https://b.corp.google.com/issues/412320087 2025-04-21T02:13:55Z Taylor Mullen ntaylormullen@google.com 2025-04-21T02:10:23Z urn:sha1:63f864cdd79a0357ec1e0474586fb00a0ec7d91b - There were a few hiccups here. Somehow 2.5-flash wasn't actually abiding by our tool schema. Instead it was inferring `path`. To semi-combat this I've renamed `file_path` -> `path`. - We weren't elevating errors that were created via schema validation. Instead both the `glob` and `read-file.ts` now surface this. - In error scenarios (like failing schema) we were improperly surfacing these as success cases because we were overriding tool status. 2025-04-20T15:22:17Z Olcan olcans@gmail.com 2025-04-20T15:22:17Z urn:sha1:99f5ed9ecb2aa491612ecaed4139cdeda086681f 2025-04-19T18:45:42Z Evan Senter evansenter@gmail.com 2025-04-19T18:45:42Z urn:sha1:3fce6cea27d3e6129d6c06e528b62e1b11bf7094 * Starting to move a lot of code into packages/server * More of the massive refactor, builds and runs, some issues though. * Fixing outstanding issue with double messages. * Fixing a minor UI issue. * Fixing the build post-merge. * Running formatting. * Addressing comments. 2025-04-19T00:44:24Z Tyler teeler@gmail.com 2025-04-19T00:44:24Z urn:sha1:4354458cadc74fe85f885374506dbde0f1924bc9 2025-04-19T00:12:14Z Allen Hutchison adh@google.com 2025-04-19T00:12:14Z urn:sha1:e75f0722e7cc780659951baee058095ed2916a9e * Bump the character limit to web fetch. * Piped Input Hook. First step in bringing in STDIN piping. * Fix linting errors. * Remove incorrect comment. 2025-04-18T23:14:36Z Taylor Mullen ntaylormullen@google.com 2025-04-18T23:09:41Z urn:sha1:40e11e053c1cf304255c21f91e950c520285c6c5 - Also updated ci.yml to ensure that linting failures will break the build. Fully fixes https://b.corp.google.com/issues/411384603 2025-04-18T22:10:57Z Taylor Mullen ntaylormullen@google.com 2025-04-18T22:08:43Z urn:sha1:383b9177848eeefb8c123a7a7ecc0ee391380eea - This has the entirety of the changes. Part of https://b.corp.google.com/issues/411720532 2025-04-18T20:20:39Z Allen Hutchison allen@hutchison.org 2025-04-18T20:20:39Z urn:sha1:3ed61f1ff25a50b94cb6a6235c67eb3c9d4737e7 * Adding a web fetch tool.