[no description] http://cgit.wit.com/dev/gemini-cli/atom?h=v0.2.2 2025-04-21T18:49:46Z 2025-04-21T18:49:46Z Jaana Dogan jbd@google.com 2025-04-21T18:49:46Z urn:sha1:651a5434036f1906f19523f1265686c168305060 This module is no longer needed and the types can be provided from types. 2025-04-21T15:07:09Z Taylor Mullen ntaylormullen@google.com 2025-04-21T14:53:11Z urn:sha1:81f0f618f7ecc439e67447bf98065d87e22483c0 - The tl;dr; is that GC couldn't see what the user was saying when tool call events happened in response. The rason why this was happening was because we were instantly invoking tools that the model told us to invoke and then instantly re-requesting. This resulted in the bug because the genai APIs can't update the chat history before a full response has been completed (doesn't know how to update if it's incomplete). - To address the above issue I had to do quite the large refactor. The gist is that now turns truly drive everything on the server (vs. a server client split). This ensured that when we got tool invocations we could control when/how re-requesting would happen and then also ensure that history was updated. This change also meant that the server would act as an event publisher to enable the client to react to events rather than try and weave in complex logic between the events. - A BIG change that this changeset incudes is the removal of all of the CLI tools in favor of the server tools. - Removed some dead code as part of this - **NOTE: Confirmations are still broken (they were broken prior to this); however, I've set them up to be able to work in the future, I'll dot hat in a follow up to be less breaking to others.** Fixes https://b.corp.google.com/issues/412320087 2025-04-19T18:45:42Z Evan Senter evansenter@gmail.com 2025-04-19T18:45:42Z urn:sha1:3fce6cea27d3e6129d6c06e528b62e1b11bf7094 * Starting to move a lot of code into packages/server * More of the massive refactor, builds and runs, some issues though. * Fixing outstanding issue with double messages. * Fixing a minor UI issue. * Fixing the build post-merge. * Running formatting. * Addressing comments. 2025-04-19T17:07:24Z Evan Senter evansenter@gmail.com 2025-04-19T17:07:24Z urn:sha1:0c9e1ef61be7db53e6e73b7208b649cd8cbed6c3 2025-04-19T06:11:33Z Jaana Dogan jbd@google.com 2025-04-19T06:11:33Z urn:sha1:24371a39546a7802ce612c76f5a250b35a739acc 2025-04-19T00:44:24Z Tyler teeler@gmail.com 2025-04-19T00:44:24Z urn:sha1:4354458cadc74fe85f885374506dbde0f1924bc9 2025-04-18T22:10:57Z Taylor Mullen ntaylormullen@google.com 2025-04-18T22:08:43Z urn:sha1:383b9177848eeefb8c123a7a7ecc0ee391380eea - This has the entirety of the changes. Part of https://b.corp.google.com/issues/411720532 2025-04-18T18:12:18Z Jaana Dogan jbd@google.com 2025-04-18T18:12:18Z urn:sha1:3afaa8033bdd9d6af99ff378cafcd84afd76c59e * Introduce a config module to manage configuration * Remove public modifier 2025-04-18T18:02:09Z Taylor Mullen ntaylormullen@google.com 2025-04-18T17:37:51Z urn:sha1:7cd3b95317c4d9263e514f33589cb359766d463b - As part of this work I also started building out errors.ts which will be a cumulation of error helpers to better handle the challenging `catch (error: unknown)` requirement. - More changes are to come, this is truly a partial change in order to not disrupt as many people as possible. Part of https://b.corp.google.com/issues/411384603 2025-04-18T17:36:33Z Evan Senter evansenter@gmail.com 2025-04-18T17:32:20Z urn:sha1:f6a4a5c44d5e73221b9e3828b6a7895b2f46feac This reverts commit 1bfc62dcc2c10e962d4a67009027b7187e690d03.